[
https://issues.apache.org/jira/browse/BEAM-1628?focusedWorklogId=171714&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171714
]
ASF GitHub Bot logged work on BEAM-1628:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/18 21:22
Start Date: 03/Dec/18 21:22
Worklog Time Spent: 10m
Work Description: angoenka commented on issue #7187: [BEAM-1628] Allow
empty port for flink master url
URL: https://github.com/apache/beam/pull/7187#issuecomment-443875054
Run Portable_Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 171714)
Time Spent: 0.5h (was: 20m)
> Flink runner: logic around --flinkMaster is error-prone
> -------------------------------------------------------
>
> Key: BEAM-1628
> URL: https://issues.apache.org/jira/browse/BEAM-1628
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Davor Bonaci
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: newbie, starter
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The logic for handling {{--flinkMaster}} seems not particularly user-friendly.
> https://github.com/apache/beam/blob/fbcde4cdc7d68de8734bf540c079b2747631a854/runners/flink/runner/src/main/java/org/apache/beam/runners/flink/FlinkPipelineExecutionEnvironment.java#L132
> {code}
> if (masterUrl.equals("[local]")) {
> } else if (masterUrl.equals("[collection]")) {
> } else if (masterUrl.equals("[auto]")) {
> } else if (masterUrl.matches(".*:\\d*")) {
> } else {
> // use auto.
> }
> {code}
> The options are constructed with "auto" set as default.
> I think we should do the following:
> * I assume there's a default port for the Flink master. We should default to
> it.
> * We should treat a string without a colon as a host name. (Not default to
> local execution.)
> This is super easy fix, hopefully someone can pick it up quickly ;-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
