[
https://issues.apache.org/jira/browse/BEAM-6181?focusedWorklogId=172491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172491
]
ASF GitHub Bot logged work on BEAM-6181:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/18 22:04
Start Date: 05/Dec/18 22:04
Worklog Time Spent: 10m
Work Description: ajamato commented on a change in pull request #7202:
[BEAM-6181] Reporting user counters via MonitoringInfos in Portable Dataflow
Runner.
URL: https://github.com/apache/beam/pull/7202#discussion_r238894238
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -351,7 +395,104 @@ void updateProgress() {
}
}
- private void updateMetrics(BeamFnApi.Metrics metrics) {
+ // todomigryz: define counter transformer factory (read wiki for proper
name)
+ // that can provide respective counter transformer for different type of
counters.
+ // (ie RowCountCounterTranformer, MSecCounterTransformer,
UserCounterTransformer, etc)
+ private static class MonitoringInfoToCounterUpdateTransformer {
+
+ private final Map<String, DataflowStepContext> transformIdMapping;
+
+ public MonitoringInfoToCounterUpdateTransformer(
+ final Map<String, DataflowStepContext> transformIdMapping) {
+ this.transformIdMapping = transformIdMapping;
+ }
+
+ // todo: search code for "beam:metrics"... and replace them with
relevant enums from
+ // proto after rebasing above https://github.com/apache/beam/pull/6799
that
+ // introduces relevant proto entries.
+ final String BEAM_METRICS_USER_PREFIX = "beam:metric:user";
+
+ private CounterUpdate monitoringInfoToCounterUpdate(MonitoringInfo
monitoringInfo) {
+ long value =
monitoringInfo.getMetric().getCounterData().getInt64Value();
+ String urn = monitoringInfo.getUrn();
+
+ String type = monitoringInfo.getType();
+
+ // todo: run MonitoringInfo through validation process.
+ // refer to https://github.com/apache/beam/pull/6799
+
+ if (urn.startsWith(BEAM_METRICS_USER_PREFIX)) {
Review comment:
Architectural suggestion would be to use polymorphism instead of a switch
statement,
Make a class/object responsible for each URN.
Though I think much of it can be common, like label extraction/conversion.
Let's come up with something that will support some default behaviour and allow
you to override it with specific URN needs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172491)
Time Spent: 1.5h (was: 1h 20m)
> Utilize MetricInfo for reporting user metrics in Portable Dataflow Java
> Runner.
> -------------------------------------------------------------------------------
>
> Key: BEAM-6181
> URL: https://issues.apache.org/jira/browse/BEAM-6181
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> New approach to report metrics in FnApi is to utilize MetricInfo structures.
> This approach is implemented in Python SDK and work is ongoing in Java SDK.
> This tasks includes plumbing User metrics reported via MetricInfos through
> Dataflow Java Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
