[
https://issues.apache.org/jira/browse/BEAM-6181?focusedWorklogId=172684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172684
]
ASF GitHub Bot logged work on BEAM-6181:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/18 16:51
Start Date: 06/Dec/18 16:51
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7202:
[BEAM-6181] Reporting user counters via MonitoringInfos in Portable Dataflow
Runner.
URL: https://github.com/apache/beam/pull/7202#discussion_r239520301
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -139,30 +150,44 @@ private AutoCloseable
progressTrackerCloseable(ProgressTracker progressTracker)
*/
@Override
public Iterable<CounterUpdate> extractMetricUpdates() {
+ List<CounterUpdate> result = progressTracker.extractCounterUpdates();
+ if ((result != null) && (result.size() > 0)) {
+ return result;
+ }
+
+ // BeamFnApi.Metrics was deprecated and replaced with more flexible
MonitoringInfo.
+ // However some of SDKs have implementations that utilize
BeamFnApi.Metrics and were not yet
+ // migrated to using new approach.
+ // Falling back to using deprecated approach until all officially
supported SDKs complete migration.
Review comment:
Is there a JIRA that tracks this migration?
More generally: is it possible to make this comment more actionable?
Something of the form: `once this condition is true (all SDKs are migrated), do
this action (remove this fallback)`. It should be straightforward for anybody
to check on the migration status and then delete the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172684)
Time Spent: 3h 50m (was: 3h 40m)
> Utilize MetricInfo for reporting user metrics in Portable Dataflow Java
> Runner.
> -------------------------------------------------------------------------------
>
> Key: BEAM-6181
> URL: https://issues.apache.org/jira/browse/BEAM-6181
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> New approach to report metrics in FnApi is to utilize MetricInfo structures.
> This approach is implemented in Python SDK and work is ongoing in Java SDK.
> This tasks includes plumbing User metrics reported via MetricInfos through
> Dataflow Java Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
