[
https://issues.apache.org/jira/browse/BEAM-6181?focusedWorklogId=174275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-174275
]
ASF GitHub Bot logged work on BEAM-6181:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Dec/18 20:58
Start Date: 11/Dec/18 20:58
Worklog Time Spent: 10m
Work Description: robertwb closed pull request #7250: [BEAM-6181]
Unexpected metrics should be non-fatal.
URL: https://github.com/apache/beam/pull/7250
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
index 6c1d43f952f9..1127a17242a5 100644
---
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
+++
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
@@ -424,24 +424,27 @@ private CounterUpdate
monitoringInfoToCounterUpdate(MonitoringInfo monitoringInf
// Requires https://github.com/apache/beam/pull/6799 to be merged.
if (urn.startsWith(BEAM_METRICS_USER_PREFIX)) {
if (!type.equals("beam:metrics:sum_int_64")) {
- throw new RuntimeException(
+ LOG.info(
"Encountered user-counter MonitoringInfo with unexpected type."
+ "Expected: beam:metrics:sum_int_64. Received: "
+ monitoringInfo.toString());
+ return null;
}
final String ptransform =
monitoringInfo.getLabelsMap().get("PTRANSFORM");
if (ptransform == null) {
- throw new RuntimeException(
+ LOG.info(
"Encountered user-counter MonitoringInfo with missing
ptransformId: "
+ monitoringInfo.toString());
+ return null;
}
DataflowStepContext stepContext = transformIdMapping.get(ptransform);
if (stepContext == null) {
- throw new RuntimeException(
+ LOG.info(
"Encountered user-counter MonitoringInfo with unknown
ptransformId: "
+ monitoringInfo.toString());
+ return null;
}
CounterStructuredNameAndMetadata name = new
CounterStructuredNameAndMetadata();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 174275)
Time Spent: 7h 20m (was: 7h 10m)
> Utilize MetricInfo for reporting user metrics in Portable Dataflow Java
> Runner.
> -------------------------------------------------------------------------------
>
> Key: BEAM-6181
> URL: https://issues.apache.org/jira/browse/BEAM-6181
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> New approach to report metrics in FnApi is to utilize MetricInfo structures.
> This approach is implemented in Python SDK and work is ongoing in Java SDK.
> This tasks includes plumbing User metrics reported via MetricInfos through
> Dataflow Java Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
