[
https://issues.apache.org/jira/browse/BEAM-6181?focusedWorklogId=172881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172881
]
ASF GitHub Bot logged work on BEAM-6181:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/18 23:29
Start Date: 06/Dec/18 23:29
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7202:
[BEAM-6181] Reporting user counters via MonitoringInfos in Portable Dataflow
Runner.
URL: https://github.com/apache/beam/pull/7202#discussion_r239652977
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -423,32 +420,28 @@ private CounterUpdate
monitoringInfoToCounterUpdate(MonitoringInfo monitoringInf
String type = monitoringInfo.getType();
- // todomigryz: run MonitoringInfo through validation process.
- // refer to https://github.com/apache/beam/pull/6799
-
+ // todo(migryz): run MonitoringInfo through Proto validation process.
+ // Requires https://github.com/apache/beam/pull/6799 to be merged.
if (urn.startsWith(BEAM_METRICS_USER_PREFIX)) {
if (!type.equals("beam:metrics:sum_int_64")) {
- LOG.warn(
+ throw new RuntimeException(
"Ignoring user-counter MonitoringInfo with unexpected type."
Review comment:
These error messages don't quite make sense for throwing exceptions. We're
no longer ignoring them, we're failing execution. Suggestion:
```java
throw new RuntimeException("Encountered MonitoringInfo with unexpected type.
Expected [..]")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 172881)
Time Spent: 5h 40m (was: 5.5h)
> Utilize MetricInfo for reporting user metrics in Portable Dataflow Java
> Runner.
> -------------------------------------------------------------------------------
>
> Key: BEAM-6181
> URL: https://issues.apache.org/jira/browse/BEAM-6181
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> New approach to report metrics in FnApi is to utilize MetricInfo structures.
> This approach is implemented in Python SDK and work is ongoing in Java SDK.
> This tasks includes plumbing User metrics reported via MetricInfos through
> Dataflow Java Runner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
