[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=177048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177048
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/18 15:48
Start Date: 19/Dec/18 15:48
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on a change in pull request
#7318: [BEAM-5315] [BEAM-5627] [BEAM-5623] Python 3 port io.filesystem module
URL: https://github.com/apache/beam/pull/7318#discussion_r242966689
##########
File path: sdks/python/apache_beam/io/filesystem.py
##########
@@ -209,7 +209,7 @@ def _fetch_to_internal_buffer(self, num_bytes):
# objects for the unused compressed data.
if (self._compression_type == CompressionTypes.BZIP2 or
self._compression_type == CompressionTypes.GZIP):
- if self._decompressor.unused_data != '':
+ if self._decompressor.unused_data != b'':
Review comment:
This change fixes the hanging tests.
This code block resulted in an infinite loop when
`self._decompressor.unused_data = b''`. On Python 2, this was not an issue
since `b'' == ''`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 177048)
Time Spent: 7h 20m (was: 7h 10m)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
