[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=179269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-179269
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Dec/18 22:44
Start Date: 27/Dec/18 22:44
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #7358: [BEAM-5315]
Python 3 port io.*_trackers modules
URL: https://github.com/apache/beam/pull/7358#discussion_r244236498
##########
File path: sdks/python/apache_beam/io/range_trackers.py
##########
@@ -390,13 +390,13 @@ def _string_to_int(s, prec):
if not s:
return 0
elif len(s) < prec:
- s += '\0' * (prec - len(s))
+ s += b'\0' * (prec - len(s))
else:
s = s[:prec]
return int(codecs.encode(s, 'hex'), 16)
@staticmethod
- def _string_from_int(i, prec):
+ def _bytestring_from_int(i, prec):
Review comment:
nit: s/string/bytestring/ on line 401.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 179269)
Time Spent: 9h 10m (was: 9h)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
