[
https://issues.apache.org/jira/browse/BEAM-5449?focusedWorklogId=177073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177073
]
ASF GitHub Bot logged work on BEAM-5449:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/18 16:45
Start Date: 19/Dec/18 16:45
Worklog Time Spent: 10m
Work Description: swegner closed pull request #7295: [BEAM-5449] Tagging
failing ULR ValidatesRunner tests.
URL: https://github.com/apache/beam/pull/7295
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/direct-java/build.gradle b/runners/direct-java/build.gradle
index 6bdf1faa8eb9..8a52ca7e7cb7 100644
--- a/runners/direct-java/build.gradle
+++ b/runners/direct-java/build.gradle
@@ -160,24 +160,32 @@ createJavaExamplesArchetypeValidationTask(type:
'MobileGaming',
createPortableValidatesRunnerTask(
jobServerDriver:
"org.apache.beam.runners.direct.portable.job.ReferenceRunnerJobServer",
testClasspathConfiguration: configurations.validatesPortableRunner,
+ jobServerConfig: "--port=0",
testCategories: {
includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
excludeCategories
'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders'
excludeCategories 'org.apache.beam.sdk.testing.LargeKeys$Above100MB'
- excludeCategories 'org.apache.beam.sdk.testing.UsesAttemptedMetrics'
- excludeCategories 'org.apache.beam.sdk.testing.UsesCommittedMetrics'
- excludeCategories 'org.apache.beam.sdk.testing.UsesCounterMetrics'
excludeCategories
'org.apache.beam.sdk.testing.UsesCustomWindowMerging'
excludeCategories
'org.apache.beam.sdk.testing.UsesDistributionMetrics'
excludeCategories 'org.apache.beam.sdk.testing.UsesFailureMessage'
- excludeCategories 'org.apache.beam.sdk.testing.UsesGaugeMetrics'
excludeCategories 'org.apache.beam.sdk.testing.UsesParDoLifecycle'
- excludeCategories 'org.apache.beam.sdk.testing.UsesMapState'
- excludeCategories 'org.apache.beam.sdk.testing.UsesSetState'
excludeCategories 'org.apache.beam.sdk.testing.UsesTestStream'
- //SplitableDoFnTests
+ // TODO(BEAM-5452): Support metrics.
+ excludeCategories 'org.apache.beam.sdk.testing.UsesGaugeMetrics'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesAttemptedMetrics'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesCommittedMetrics'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesCounterMetrics'
+ // TODO(BEAM-3743): Support SplittableDoFn
excludeCategories
'org.apache.beam.sdk.testing.UsesBoundedSplittableParDo'
excludeCategories
'org.apache.beam.sdk.testing.UsesSplittableParDoWithWindowedSideInputs'
excludeCategories
'org.apache.beam.sdk.testing.UsesUnboundedSplittableParDo'
+ // TODO(BEAM-2928): Support sideinput.
+ excludeCategories 'org.apache.beam.sdk.testing.UsesSideInputs'
+ // TODO(BEAM-2917): Support user state.
+ excludeCategories 'org.apache.beam.sdk.testing.UsesStatefulParDo'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesMapState'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesSetState'
+ // TODO(BEAM-4680): Support user timers.
+ excludeCategories 'org.apache.beam.sdk.testing.UsesTimersInParDo'
},
)
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CountingSourceTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CountingSourceTest.java
index 8cacd670c628..013cef77a227 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CountingSourceTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/io/CountingSourceTest.java
@@ -34,6 +34,7 @@
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.testing.UsesStatefulParDo;
import org.apache.beam.sdk.testing.ValidatesRunner;
import org.apache.beam.sdk.transforms.Count;
import org.apache.beam.sdk.transforms.Distinct;
@@ -92,7 +93,11 @@ public void testEmptyBoundedSource() {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesStatefulParDo.class, // This test fails if State is unsupported
despite no direct usage.
+ DataflowPortabilityApiUnsupported.class
+ })
public void testBoundedSourceSplits() throws Exception {
long numElements = 1000;
long numSplits = 10;
@@ -214,7 +219,11 @@ public void testUnboundedSourceWithRate() {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesStatefulParDo.class, // This test fails if State is unsupported
despite no direct usage.
+ DataflowPortabilityApiUnsupported.class
+ })
public void testUnboundedSourceSplits() throws Exception {
long numElements = 1000;
int numSplits = 10;
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
index 160f709bd9fc..8fd2a901658d 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
@@ -306,7 +306,11 @@ public void testIsEqualTo() throws Exception {
/** Basic test for {@code isEqualTo}. */
@Test
- @Category({ValidatesRunner.class,
DataflowPortabilityExecutableStageUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesStatefulParDo.class, // This test fails if State is unsupported
despite no direct usage.
+ DataflowPortabilityExecutableStageUnsupported.class
+ })
public void testWindowedIsEqualTo() throws Exception {
PCollection<Integer> pcollection =
pipeline
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineFnsTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineFnsTest.java
index c2c7a846477a..ba279fd6308d 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineFnsTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineFnsTest.java
@@ -40,6 +40,7 @@
import org.apache.beam.sdk.testing.DataflowPortabilityApiUnsupported;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.testing.UsesSideInputs;
import org.apache.beam.sdk.testing.ValidatesRunner;
import org.apache.beam.sdk.transforms.Combine.BinaryCombineFn;
import org.apache.beam.sdk.transforms.CombineFns.CoCombineResult;
@@ -97,7 +98,7 @@ public void testDuplicatedTagsWithContext() {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class, UsesSideInputs.class,
DataflowPortabilityApiUnsupported.class})
public void testComposedCombine() {
p.getCoderRegistry().registerCoderForClass(UserString.class,
UserStringCoder.of());
@@ -147,7 +148,7 @@ public void testComposedCombine() {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({ValidatesRunner.class, UsesSideInputs.class,
DataflowPortabilityApiUnsupported.class})
public void testComposedCombineWithContext() {
p.getCoderRegistry().registerCoderForClass(UserString.class,
UserStringCoder.of());
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java
index 21f7cdaac426..fc0165bc6fbb 100644
---
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java
+++
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CombineTest.java
@@ -648,7 +648,11 @@ public int sum(Iterable<Integer> integers) {
@RunWith(JUnit4.class)
public static class BasicTests extends SharedTestBase {
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesSideInputs.class,
+ DataflowPortabilityApiUnsupported.class
+ })
@SuppressWarnings({"rawtypes", "unchecked"})
public void testSimpleCombine() {
runTestSimpleCombine(
@@ -658,7 +662,11 @@ public void testSimpleCombine() {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesSideInputs.class,
+ DataflowPortabilityApiUnsupported.class
+ })
public void testSimpleCombineEmpty() {
runTestSimpleCombine(EMPTY_TABLE, 0, Collections.emptyList());
}
@@ -1024,7 +1032,11 @@ public void testFixedWindowsCombine() {
}
@Test
- @Category({ValidatesRunner.class,
DataflowPortabilityExecutableStageUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesSideInputs.class,
+ DataflowPortabilityExecutableStageUnsupported.class
+ })
public void testFixedWindowsCombineWithContext() {
PCollection<KV<String, Integer>> perKeyInput =
pipeline
@@ -1125,7 +1137,11 @@ public void testSlidingWindowsCombine() {
}
@Test
- @Category({ValidatesRunner.class,
DataflowPortabilityExecutableStageUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesSideInputs.class,
+ DataflowPortabilityExecutableStageUnsupported.class
+ })
public void testSlidingWindowsCombineWithContext() {
// [a: 1, 1], [a: 4; b: 1], [b: 13]
PCollection<KV<String, Integer>> perKeyInput =
@@ -1229,7 +1245,11 @@ public void testSessionsCombine() {
}
@Test
- @Category({ValidatesRunner.class,
DataflowPortabilityExecutableStageUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesSideInputs.class,
+ DataflowPortabilityExecutableStageUnsupported.class
+ })
public void testSessionsCombineWithContext() {
PCollection<KV<String, Integer>> perKeyInput =
pipeline.apply(
@@ -1320,7 +1340,11 @@ public void processElement(ProcessContext c) {
}
@Test
- @Category({ValidatesRunner.class,
DataflowPortabilityExecutableStageUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesSideInputs.class,
+ DataflowPortabilityExecutableStageUnsupported.class
+ })
public void testWindowedCombineGloballyAsSingletonView() {
FixedWindows windowFn = FixedWindows.of(Duration.standardMinutes(1));
final PCollectionView<Integer> view =
@@ -1401,7 +1425,11 @@ public void testCombineGloballyInstanceMethodReference()
{
@RunWith(JUnit4.class)
public static class AccumulationTests extends SharedTestBase {
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesSideInputs.class,
+ DataflowPortabilityApiUnsupported.class
+ })
public void testAccumulatingCombine() {
runTestAccumulatingCombine(
Arrays.asList(KV.of("a", 1), KV.of("a", 1), KV.of("a", 4),
KV.of("b", 1), KV.of("b", 13)),
@@ -1410,7 +1438,11 @@ public void testAccumulatingCombine() {
}
@Test
- @Category({ValidatesRunner.class, DataflowPortabilityApiUnsupported.class})
+ @Category({
+ ValidatesRunner.class,
+ UsesSideInputs.class,
+ DataflowPortabilityApiUnsupported.class
+ })
public void testAccumulatingCombineEmpty() {
runTestAccumulatingCombine(EMPTY_TABLE, 0.0, Collections.emptyList());
}
diff --git
a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ViewTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ViewTest.java
index f70ca9ac7c25..7ad452053274 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ViewTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ViewTest.java
@@ -50,6 +50,7 @@
import org.apache.beam.sdk.testing.NeedsRunner;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.testing.UsesSideInputs;
import org.apache.beam.sdk.testing.ValidatesRunner;
import org.apache.beam.sdk.transforms.windowing.FixedWindows;
import org.apache.beam.sdk.transforms.windowing.GlobalWindows;
@@ -77,6 +78,7 @@
* views can only be observed via {@link ParDo}.
*/
@RunWith(JUnit4.class)
+@Category(UsesSideInputs.class)
public class ViewTest implements Serializable {
// This test is Serializable, just so that it's easy to have
// anonymous inner classes inside the non-static test methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 177073)
Time Spent: 50m (was: 40m)
> Add ValidatesRunner tests for the ULR, including automated Pre- and
> Post-commits.
> ---------------------------------------------------------------------------------
>
> Key: BEAM-5449
> URL: https://issues.apache.org/jira/browse/BEAM-5449
> Project: Beam
> Issue Type: Sub-task
> Components: runner-direct
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The ULR should have working ValidatesRunner tests that can be used by devs,
> as well as automated testing support for them on the Apache Beam Jenkins.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
