[
https://issues.apache.org/jira/browse/BEAM-6161?focusedWorklogId=177232&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177232
]
ASF GitHub Bot logged work on BEAM-6161:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/18 22:41
Start Date: 19/Dec/18 22:41
Worklog Time Spent: 10m
Work Description: ajamato commented on a change in pull request #7272:
[BEAM-6161] Introduce PCollectionConsumerRegistry and add ElementCoun…
URL: https://github.com/apache/beam/pull/7272#discussion_r243096192
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/RemoteExecutionTest.java
##########
@@ -584,21 +584,28 @@ public void onProgress(ProcessBundleProgressResponse
progress) {}
@Override
public void onCompleted(ProcessBundleResponse response) {
// Assert the timestamps are non empty then 0 them out before
comparing.
- List<MonitoringInfo> actualMIs = new ArrayList<>();
+ List<MonitoringInfo> actual = new ArrayList<MonitoringInfo>();
for (MonitoringInfo mi : response.getMonitoringInfosList()) {
MonitoringInfo.Builder builder = MonitoringInfo.newBuilder();
Assert.assertTrue(mi.getTimestamp().getSeconds() > 0);
builder.mergeFrom(mi);
builder.clearTimestamp();
- actualMIs.add(builder.build());
+ actual.add(builder.build());
}
SimpleMonitoringInfoBuilder builder = new
SimpleMonitoringInfoBuilder();
builder.setUrnForUserMetric(RemoteExecutionTest.class.getName(),
counterMetricName);
builder.setInt64Value(2);
- MonitoringInfo expectedCounter = builder.build();
+ MonitoringInfo userCounter = builder.build();
- assertThat(actualMIs, CoreMatchers.hasItems(expectedCounter));
+ builder = new SimpleMonitoringInfoBuilder();
+ builder.setUrn(SimpleMonitoringInfoBuilder.ELEMENT_COUNT_URN);
+ builder.setPCollectionLabel("impulse.out");
+ builder.setInt64Value(2);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 177232)
Time Spent: 3h 10m (was: 3h)
> Add ElementCount MonitoringInfos for the Java SDK
> -------------------------------------------------
>
> Key: BEAM-6161
> URL: https://issues.apache.org/jira/browse/BEAM-6161
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution, sdk-java-harness
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
