[
https://issues.apache.org/jira/browse/BEAM-6161?focusedWorklogId=177286&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177286
]
ASF GitHub Bot logged work on BEAM-6161:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/18 02:01
Start Date: 20/Dec/18 02:01
Worklog Time Spent: 10m
Work Description: ajamato commented on a change in pull request #7272:
[BEAM-6161] Introduce PCollectionConsumerRegistry and add ElementCoun…
URL: https://github.com/apache/beam/pull/7272#discussion_r243113191
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/DelegatingCounter.java
##########
@@ -0,0 +1,64 @@
+/*
Review comment:
this metrics package does not have tests for every file inside, so I don't
want to add an unnecessary test here. This is just a refactoring of existing
code. Its being tested
I don't see this test as adding much value because this code is already
tested very well with the existing tests since this is a class used to
implement the others in the package. Specifically MetricContainerImpl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 177286)
> Add ElementCount MonitoringInfos for the Java SDK
> -------------------------------------------------
>
> Key: BEAM-6161
> URL: https://issues.apache.org/jira/browse/BEAM-6161
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution, sdk-java-harness
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
