[
https://issues.apache.org/jira/browse/BEAM-6300?focusedWorklogId=178265&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-178265
]
ASF GitHub Bot logged work on BEAM-6300:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/18 16:06
Start Date: 22/Dec/18 16:06
Worklog Time Spent: 10m
Work Description: kanterov commented on a change in pull request #7345:
[BEAM-6300] Put generated getter/setter/creator classes in the same package as
the class they access
URL: https://github.com/apache/beam/pull/7345#discussion_r243740246
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ByteBuddyUtils.java
##########
@@ -59,6 +62,40 @@
private static final ForLoadedType READABLE_INSTANT_TYPE =
new ForLoadedType(ReadableInstant.class);
+ /**
+ * A naming strategy for ByteBuddy classes.
+ *
+ * <p>We always inject the generatter classes in the same same package as
the user's target class.
+ *
+ * @kanterov kanterov 20 hours ago Contributor nit: s/generatter/generated/
Review comment:
probably in https://github.com/apache/beam/pull/7334
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 178265)
Time Spent: 50m (was: 40m)
> Generated row object for POJOs, Avros, and JavaBeans should work if the
> wrapped class is package private
> --------------------------------------------------------------------------------------------------------
>
> Key: BEAM-6300
> URL: https://issues.apache.org/jira/browse/BEAM-6300
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We should put the byte-buddy generated classes in the same package as the
> class they are accessing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
