[
https://issues.apache.org/jira/browse/BEAM-6300?focusedWorklogId=178267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-178267
]
ASF GitHub Bot logged work on BEAM-6300:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/18 16:14
Start Date: 22/Dec/18 16:14
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #7345: [BEAM-6300] Put
generated getter/setter/creator classes in the same package as the class they
access
URL: https://github.com/apache/beam/pull/7345#issuecomment-449580823
Yeah, saw that too. already one it.
On Sat, Dec 22, 2018 at 8:05 AM Gleb Kanterov <[email protected]>
wrote:
> *@kanterov* commented on this pull request.
> ------------------------------
>
> In
>
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ByteBuddyUtils.java
> <https://github.com/apache/beam/pull/7345#discussion_r243740216>:
>
> > @@ -59,6 +62,40 @@
> private static final ForLoadedType READABLE_INSTANT_TYPE =
> new ForLoadedType(ReadableInstant.class);
>
> + /**
> + * A naming strategy for ByteBuddy classes.
> + *
> + * <p>We always inject the generatter classes in the same same package
as the user's target class.
> + *
> + * @kanterov kanterov 20 hours ago Contributor nit:
s/generatter/generated/
>
> not a big deal, let's fix it later
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/7345#pullrequestreview-187596108>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AUGE1RkTbK9ckuy3gmvojMIs_errym5oks5u7lg7gaJpZM4Zfc8U>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 178267)
Time Spent: 1h 10m (was: 1h)
> Generated row object for POJOs, Avros, and JavaBeans should work if the
> wrapped class is package private
> --------------------------------------------------------------------------------------------------------
>
> Key: BEAM-6300
> URL: https://issues.apache.org/jira/browse/BEAM-6300
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We should put the byte-buddy generated classes in the same package as the
> class they are accessing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
