[ 
https://issues.apache.org/jira/browse/BEAM-5798?focusedWorklogId=180837&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-180837
 ]

ASF GitHub Bot logged work on BEAM-5798:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jan/19 19:12
            Start Date: 03/Jan/19 19:12
    Worklog Time Spent: 10m 
      Work Description: rangadi commented on pull request #7371: [BEAM-5798] 
Add support of multiple Kafka output topics
URL: https://github.com/apache/beam/pull/7371#discussion_r245097150
 
 

 ##########
 File path: 
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaWriter.java
 ##########
 @@ -56,15 +55,14 @@ public void processElement(ProcessContext ctx) throws 
Exception {
     checkForFailures();
 
     ProducerRecord<K, V> record = ctx.element();
-    KV<K, V> kv = KV.of(record.key(), record.value());
-
     Long timestampMillis =
 
 Review comment:
   Just noticed, we should honor timestamp in the producer record if 
getPublishTimestampFunction() is not set.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 180837)
    Time Spent: 2h 40m  (was: 2.5h)

> Add support for dynamic destinations when writing to Kafka
> ----------------------------------------------------------
>
>                 Key: BEAM-5798
>                 URL: https://issues.apache.org/jira/browse/BEAM-5798
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-kafka
>            Reporter: Luke Cwik
>            Assignee: Alexey Romanenko
>            Priority: Major
>              Labels: newbie, starter
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Add support for writing to Kafka based upon contents of the data. This is 
> similar to the dynamic destination approach for file IO and other sinks.
>  
> Source of request: 
> https://lists.apache.org/thread.html/a89d1d32ecdb50c42271e805cc01a651ee3623b4df97c39baf4f2053@%3Cuser.beam.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to