[
https://issues.apache.org/jira/browse/BEAM-5798?focusedWorklogId=181119&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-181119
]
ASF GitHub Bot logged work on BEAM-5798:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/19 13:38
Start Date: 04/Jan/19 13:38
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #7371:
[BEAM-5798] Add support of multiple Kafka output topics
URL: https://github.com/apache/beam/pull/7371#discussion_r245270787
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaWriter.java
##########
@@ -56,15 +55,14 @@ public void processElement(ProcessContext ctx) throws
Exception {
checkForFailures();
ProducerRecord<K, V> record = ctx.element();
- KV<K, V> kv = KV.of(record.key(), record.value());
-
Long timestampMillis =
Review comment:
I updated this part in the same way as we do with topics.
`ProducerRecord.timestamp()` has more priority (in case if user set it manually
before) than `getPublishTimestampFunction()`. If it was not set then we try to
get timestamp from `getPublishTimestampFunction()` . Otherwise, we just use
system time.
Looks ok for you such approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 181119)
Time Spent: 3h 40m (was: 3.5h)
> Add support for dynamic destinations when writing to Kafka
> ----------------------------------------------------------
>
> Key: BEAM-5798
> URL: https://issues.apache.org/jira/browse/BEAM-5798
> Project: Beam
> Issue Type: New Feature
> Components: io-java-kafka
> Reporter: Luke Cwik
> Assignee: Alexey Romanenko
> Priority: Major
> Labels: newbie, starter
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Add support for writing to Kafka based upon contents of the data. This is
> similar to the dynamic destination approach for file IO and other sinks.
>
> Source of request:
> https://lists.apache.org/thread.html/a89d1d32ecdb50c42271e805cc01a651ee3623b4df97c39baf4f2053@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
