[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=180851&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-180851
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/19 19:56
Start Date: 03/Jan/19 19:56
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #7394: [BEAM-5315]
Python 3 port io.textio module
URL: https://github.com/apache/beam/pull/7394#discussion_r245114813
##########
File path: sdks/python/apache_beam/io/textio_test.py
##########
@@ -53,6 +53,16 @@
from apache_beam.transforms.core import Create
+def write_data(*args, **kwargs):
Review comment:
It is hard to reason about this helper in the context of the test scenarios.
Let's copy the existing implementation of write_data into this test suite,
modify it to return strings as second tuple argument, and add a docstring
explaining the arguments and the type of result.
This would make it easier for these helpers to evolve separately. For
example, for the purposes of textio_test, I think it makes sense to allow
customizing payload instead of default 'line', and adding more interesting
testcases of unicode strings in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 180851)
Time Spent: 11h 40m (was: 11.5h)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 11h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
