[ 
https://issues.apache.org/jira/browse/BEAM-6346?focusedWorklogId=181991&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-181991
 ]

ASF GitHub Bot logged work on BEAM-6346:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jan/19 19:44
            Start Date: 07/Jan/19 19:44
    Worklog Time Spent: 10m 
      Work Description: mxm commented on pull request #7395: [BEAM-6346] 
Inspect the docker container state
URL: https://github.com/apache/beam/pull/7395#discussion_r245775105
 
 

 ##########
 File path: 
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerEnvironmentFactory.java
 ##########
 @@ -152,8 +152,10 @@ public RemoteEnvironment createEnvironment(Environment 
environment) throws Excep
       LOG.debug("Created Docker Container with Container ID {}", containerId);
       // Wait on a client from the gRPC server.
       while (instructionHandler == null) {
+        Preconditions.checkArgument(
+            docker.isContainerRunning(containerId), "No container running for 
id " + containerId);
 
 Review comment:
   The check is too strict then. We won't get `RUNNING` directly after starting 
the container. We need something like a repeated check which times out after 
some max startup time.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 181991)
    Time Spent: 1h  (was: 50m)

> Portable Flink Job hangs if the sdk harness fails to start
> ----------------------------------------------------------
>
>                 Key: BEAM-6346
>                 URL: https://issues.apache.org/jira/browse/BEAM-6346
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Ankur Goenka
>            Assignee: Ankur Goenka
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Portable beam job on Flink fails if the sdk harness container fails to start 
> as its started in detached mode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to