[
https://issues.apache.org/jira/browse/BEAM-6346?focusedWorklogId=182644&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-182644
]
ASF GitHub Bot logged work on BEAM-6346:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/19 19:48
Start Date: 08/Jan/19 19:48
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #7395: [BEAM-6346]
Inspect the docker container state
URL: https://github.com/apache/beam/pull/7395#discussion_r246128813
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerEnvironmentFactory.java
##########
@@ -152,8 +152,10 @@ public RemoteEnvironment createEnvironment(Environment
environment) throws Excep
LOG.debug("Created Docker Container with Container ID {}", containerId);
// Wait on a client from the gRPC server.
while (instructionHandler == null) {
+ Preconditions.checkArgument(
+ docker.isContainerRunning(containerId), "No container running for
id " + containerId);
Review comment:
I am not sure if the 'docker run -d <image> ' return before the container is
in running state. From running state, it can dies because of user code
error/completion.
However it makes sense to check the state after the initial suggested wait
of 1 min.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 182644)
Time Spent: 1h 10m (was: 1h)
> Portable Flink Job hangs if the sdk harness fails to start
> ----------------------------------------------------------
>
> Key: BEAM-6346
> URL: https://issues.apache.org/jira/browse/BEAM-6346
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Portable beam job on Flink fails if the sdk harness container fails to start
> as its started in detached mode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
