[
https://issues.apache.org/jira/browse/BEAM-9712?focusedWorklogId=455062&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455062
]
ASF GitHub Bot logged work on BEAM-9712:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/20 20:06
Start Date: 06/Jul/20 20:06
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #12163:
URL: https://github.com/apache/beam/pull/12163#discussion_r450452161
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/CalciteQueryPlanner.java
##########
@@ -75,7 +75,9 @@
private final Planner planner;
private final JdbcConnection connection;
- public CalciteQueryPlanner(JdbcConnection connection, RuleSet[] ruleSets) {
+ public CalciteQueryPlanner(
+ JdbcConnection connection, RuleSet[] ruleSets, String defaultTimezone) {
+ // TODO: support setting default timezone?
Review comment:
> Actually this config does not seem to apply to CalciteSQL
Why not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 455062)
Time Spent: 1h (was: 50m)
> setting default timezone doesn't work
> -------------------------------------
>
> Key: BEAM-9712
> URL: https://issues.apache.org/jira/browse/BEAM-9712
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Assignee: Robin Qiu
> Priority: P4
> Labels: zetasql-compliance
> Time Spent: 1h
> Remaining Estimate: 0h
>
> several failures in shard 14
> (note: fixing the internal tests requires plumbing through the timezone
> config.)
> {code}
> [name=timestamp_to_string_1]
> select [cast(timestamp "2015-01-28" as string),
> cast(timestamp "2015-01-28 00:00:00" as string),
> cast(timestamp "2015-01-28 00:00:00.0" as string),
> cast(timestamp "2015-01-28 00:00:00.00" as string),
> cast(timestamp "2015-01-28 00:00:00.000" as string),
> cast(timestamp "2015-01-28 00:00:00.0000" as string),
> cast(timestamp "2015-01-28 00:00:00.00000" as string),
> cast(timestamp "2015-01-28 00:00:00.000000" as string)]
> --
> ARRAY<STRUCT<ARRAY<>>>[
> {ARRAY<STRING>[
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45"
> ]}
> ]
> {code}
> {code}
> [default_time_zone=Pacific/Chatham]
> [name=timestamp_to_string_1]
> select [cast(timestamp "2015-01-28" as string),
> cast(timestamp "2015-01-28 00:00:00" as string),
> cast(timestamp "2015-01-28 00:00:00.0" as string),
> cast(timestamp "2015-01-28 00:00:00.00" as string),
> cast(timestamp "2015-01-28 00:00:00.000" as string),
> cast(timestamp "2015-01-28 00:00:00.0000" as string),
> cast(timestamp "2015-01-28 00:00:00.00000" as string),
> cast(timestamp "2015-01-28 00:00:00.000000" as string)]
> --
> ARRAY<STRUCT<ARRAY<>>>[
> {ARRAY<STRING>[
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45"
> ]}
> ]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
