[
https://issues.apache.org/jira/browse/BEAM-9712?focusedWorklogId=456746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456746
]
ASF GitHub Bot logged work on BEAM-9712:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/20 18:20
Start Date: 09/Jul/20 18:20
Worklog Time Spent: 10m
Work Description: robinyqiu commented on a change in pull request #12163:
URL: https://github.com/apache/beam/pull/12163#discussion_r452405560
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##########
@@ -182,11 +164,10 @@ ResolvedStatement analyzeNextStatement(
return resolvedStatement;
}
- static AnalyzerOptions initAnalyzerOptions() {
+ static AnalyzerOptions baseAnalyzerOptions() {
Review comment:
Thanks for the reminder! I will remember to rename them.
Reminder to @ibzib as well. I found you are also changing this file
frequently these days. Any change made here should also be made to the internal
validator code written in C++. I will sync the validator code later today to
include the changes so far. In the future if you make changes again, please
make sure you do that as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 456746)
Time Spent: 2h (was: 1h 50m)
> setting default timezone doesn't work
> -------------------------------------
>
> Key: BEAM-9712
> URL: https://issues.apache.org/jira/browse/BEAM-9712
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Assignee: Robin Qiu
> Priority: P4
> Labels: zetasql-compliance
> Time Spent: 2h
> Remaining Estimate: 0h
>
> several failures in shard 14
> (note: fixing the internal tests requires plumbing through the timezone
> config.)
> {code}
> [name=timestamp_to_string_1]
> select [cast(timestamp "2015-01-28" as string),
> cast(timestamp "2015-01-28 00:00:00" as string),
> cast(timestamp "2015-01-28 00:00:00.0" as string),
> cast(timestamp "2015-01-28 00:00:00.00" as string),
> cast(timestamp "2015-01-28 00:00:00.000" as string),
> cast(timestamp "2015-01-28 00:00:00.0000" as string),
> cast(timestamp "2015-01-28 00:00:00.00000" as string),
> cast(timestamp "2015-01-28 00:00:00.000000" as string)]
> --
> ARRAY<STRUCT<ARRAY<>>>[
> {ARRAY<STRING>[
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45"
> ]}
> ]
> {code}
> {code}
> [default_time_zone=Pacific/Chatham]
> [name=timestamp_to_string_1]
> select [cast(timestamp "2015-01-28" as string),
> cast(timestamp "2015-01-28 00:00:00" as string),
> cast(timestamp "2015-01-28 00:00:00.0" as string),
> cast(timestamp "2015-01-28 00:00:00.00" as string),
> cast(timestamp "2015-01-28 00:00:00.000" as string),
> cast(timestamp "2015-01-28 00:00:00.0000" as string),
> cast(timestamp "2015-01-28 00:00:00.00000" as string),
> cast(timestamp "2015-01-28 00:00:00.000000" as string)]
> --
> ARRAY<STRUCT<ARRAY<>>>[
> {ARRAY<STRING>[
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45",
> "2015-01-28 00:00:00+13:45"
> ]}
> ]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
