[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=455074&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455074
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/20 20:40
Start Date: 06/Jul/20 20:40
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#11243:
URL: https://github.com/apache/beam/pull/11243#discussion_r450467677
##########
File path: sdks/java/container/build.gradle
##########
@@ -68,6 +73,28 @@ golang {
}
}
+// this is a workaround to call generateLicenseReport task from project root
directory.
+// generateLicenseReport does not return correct dependency list when not
called from the root.
+task generateThirdPartyLicenses(type: Exec) {
+ workingDir project.rootProject.projectDir
+ commandLine './sdks/java/container/license_scripts/license_script.sh'
+}
+
+//command: ./gradlew generateLicenseReport
+import com.github.jk1.license.render.*
+licenseReport {
+ outputDir = 'java_third_party_licenses'
+ projects = [project.rootProject] + project.rootProject.subprojects
+ excludeOwnGroup = true
+ configurations = ALL
Review comment:
Why ALL? Should this just be `runtime`?
This pulls in lots of configurations that only are used to run static
analysis at build time, etc, and do not affect the license of the container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 455074)
Time Spent: 31.5h (was: 31h 20m)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: P2
> Fix For: 2.21.0
>
> Time Spent: 31.5h
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
