[ 
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=455075&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455075
 ]

ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jul/20 20:41
            Start Date: 06/Jul/20 20:41
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on a change in pull request 
#11243:
URL: https://github.com/apache/beam/pull/11243#discussion_r450468077



##########
File path: sdks/java/container/build.gradle
##########
@@ -68,6 +73,28 @@ golang {
   }
 }
 
+// this is a workaround to call generateLicenseReport task from project root 
directory.
+// generateLicenseReport does not return correct dependency list when not 
called from the root.
+task generateThirdPartyLicenses(type: Exec) {
+  workingDir project.rootProject.projectDir
+  commandLine './sdks/java/container/license_scripts/license_script.sh'
+}
+
+//command: ./gradlew generateLicenseReport
+import com.github.jk1.license.render.*
+licenseReport {
+  outputDir = 'java_third_party_licenses'
+  projects = [project.rootProject] + project.rootProject.subprojects
+  excludeOwnGroup = true
+  configurations = ALL

Review comment:
       I recently hit a problem where dependency resolution here is incorrect 
for one of these configurations. It is pulling versions that don't exist and 
nothing depends on.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 455075)
    Time Spent: 31h 40m  (was: 31.5h)

> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
>                 Key: BEAM-9136
>                 URL: https://issues.apache.org/jira/browse/BEAM-9136
>             Project: Beam
>          Issue Type: Task
>          Components: build-system
>            Reporter: Hannah Jiang
>            Assignee: Hannah Jiang
>            Priority: P2
>             Fix For: 2.21.0
>
>          Time Spent: 31h 40m
>  Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK 
> docker images.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to