[
https://issues.apache.org/jira/browse/BEAM-10404?focusedWorklogId=455641&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455641
]
ASF GitHub Bot logged work on BEAM-10404:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/20 18:30
Start Date: 07/Jul/20 18:30
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r451063093
##########
File path: .github/workflows/cancel.yml
##########
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review comment:
> e.g. new merge commit on master appear. So it is possible to run rests
without PR.
I do not understand how/when this would happen. Because we do not allow
direct pushes to master. And if it is already in master a PR would not be
helpful. Maybe this example applies to release branches?
Overall, I am fine with the change. It is ok to cancel tests when a new PR
is created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 455641)
Time Spent: 50m (was: 40m)
> Cancel queued/running GitHub Action builds on second push to PR
> ---------------------------------------------------------------
>
> Key: BEAM-10404
> URL: https://issues.apache.org/jira/browse/BEAM-10404
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Tobiasz Kedzierski
> Assignee: Tobiasz Kedzierski
> Priority: P2
> Labels: CI, CI/CD
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
