[
https://issues.apache.org/jira/browse/BEAM-10404?focusedWorklogId=456682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456682
]
ASF GitHub Bot logged work on BEAM-10404:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/20 15:19
Start Date: 09/Jul/20 15:19
Worklog Time Spent: 10m
Work Description: TobKed commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r452297033
##########
File path: .github/workflows/cancel.yml
##########
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review comment:
I wasn't aware that direct push to master is not allowed however merge
commits which appear on master also trigger _push_ event:
Here you can check filtered wheels builds for _push_ event on _master_:
https://github.com/apache/beam/actions?query=event%3Apush+branch%3Amaster+workflow%3A%22Build+python+wheels%22
and example of _push_ events similar on the release branch `release-2.23.0`:
https://github.com/apache/beam/actions?query=event%3Apush+branch%3Arelease-2.23.0
In comparison here are "_pull request_" events triggered on the various
branches:
https://github.com/apache/beam/actions?query=event%3Apull_request
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 456682)
Time Spent: 1h 10m (was: 1h)
> Cancel queued/running GitHub Action builds on second push to PR
> ---------------------------------------------------------------
>
> Key: BEAM-10404
> URL: https://issues.apache.org/jira/browse/BEAM-10404
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Tobiasz Kedzierski
> Assignee: Tobiasz Kedzierski
> Priority: P2
> Labels: CI, CI/CD
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
