[
https://issues.apache.org/jira/browse/BEAM-10420?focusedWorklogId=455812&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455812
]
ASF GitHub Bot logged work on BEAM-10420:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/20 02:21
Start Date: 08/Jul/20 02:21
Worklog Time Spent: 10m
Work Description: lukecwik edited a comment on pull request #12192:
URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038
R: @robertwb @chamikaramj
Progress reporting needs to be able to see which window out of how many are
being processed. Splitting needs to be able to see which window is being
processed to compute the primary and residual correctly.
Style-wise does it make sense to use the `kwargs` to pass these through or
should I continue to make them explicit like the `restriction_tracker` and
`watermark_estimator` that was provided before.
Alternatively, I could move the window observing logic outside of the
DoFnInvoker and then all the DoFnRunners would own this logic (this does seem
like it would lead to more code duplication).
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 455812)
Time Spent: 1h (was: 50m)
> PerWindowInvoker to handle window observing SplittableDoFns
> -----------------------------------------------------------
>
> Key: BEAM-10420
> URL: https://issues.apache.org/jira/browse/BEAM-10420
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Labels: portability
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently the FnApiDoFnRunner processes each element within it's own window.
> There is an easy optimization where we process the element once if and only
> if the function doesn't observe the window (either directly or indirectly via
> side inputs/state/...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
