[
https://issues.apache.org/jira/browse/BEAM-5319?focusedWorklogId=183259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183259
]
ASF GitHub Bot logged work on BEAM-5319:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/19 18:59
Start Date: 09/Jan/19 18:59
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #7445: [BEAM-5319]
Python 3 port runners module
URL: https://github.com/apache/beam/pull/7445#discussion_r246500533
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
##########
@@ -215,9 +203,6 @@ def test_gbk_side_input(self):
main | beam.Map(lambda a, b: (a, b), beam.pvalue.AsDict(side)),
equal_to([(None, {'a': [1]})]))
- @unittest.skipIf(sys.version_info[0] == 3 and
Review comment:
Is this test actually passing? I am seeing errors, but maybe it is due to
the fact I am using a different Python 3 version than we have on Jenkins.
```
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/build/third_party/py/apache_beam/runners/portability/fn_api_runner_test.py",
line 215, in test_multimap_side_input
equal_to([('a', [1, 3]), ('b', [2])]))
File "/build/third_party/py/apache_beam/pipeline.py", line 425, in __exit__
self.run().wait_until_finish()
File "/build/third_party/py/apache_beam/pipeline.py", line 405, in run
self._options).run(False)
File "/build/third_party/py/apache_beam/pipeline.py", line 418, in run
return self.runner.run_pipeline(self, self._options)
File
"/build/third_party/py/apache_beam/runners/portability/fn_api_runner.py", line
265, in run_pipeline
default_environment=self._default_environment))
File
"/build/third_party/py/apache_beam/runners/portability/fn_api_runner.py", line
268, in run_via_runner_api
return self.run_stages(*self.create_stages(pipeline_proto))
File
"/build/third_party/py/apache_beam/runners/portability/fn_api_runner.py", line
355, in run_stages
safe_coders)
File
"/build/third_party/py/apache_beam/runners/portability/fn_api_runner.py", line
449, in run_stage
elements_by_window = _WindowGroupingBuffer(si, value_coder)
File
"/build/third_party/py/apache_beam/runners/portability/fn_api_runner.py", line
191, in __init__
self._key_coder = coder.wrapped_value_coder.key_coder()
File "/build/third_party/py/apache_beam/coders/coders.py", line 177, in
key_coder
raise ValueError('Not a KV coder: %s.' % self)
ValueError: Not a KV coder: BytesCoder.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 183259)
Time Spent: 4h 20m (was: 4h 10m)
> Finish Python 3 porting for runners module
> ------------------------------------------
>
> Key: BEAM-5319
> URL: https://issues.apache.org/jira/browse/BEAM-5319
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
