[
https://issues.apache.org/jira/browse/BEAM-5319?focusedWorklogId=184960&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-184960
]
ASF GitHub Bot logged work on BEAM-5319:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/19 21:46
Start Date: 14/Jan/19 21:46
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on pull request #7445:
[BEAM-5319] Python 3 port runners module
URL: https://github.com/apache/beam/pull/7445#discussion_r247671233
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
##########
@@ -215,9 +203,6 @@ def test_gbk_side_input(self):
main | beam.Map(lambda a, b: (a, b), beam.pvalue.AsDict(side)),
equal_to([(None, {'a': [1]})]))
- @unittest.skipIf(sys.version_info[0] == 3 and
Review comment:
Only unskipping tests for passing versions would mean we would need to check
the tests for multiple versions every time, which would take some time. Leaving
all tests unskipped for higher versions also doesn't seem like the best
approach, since most will be fixed for all versions anyway.
I also think some other already unskipped tests will fail on Python 3.6+.
For instance some typehints tests related to type inference, which uses byte
code inspection, which was changed in Python 3.6.
Looking at the fastest way forward, I would like to focus solely on 3.5 for
now, and add skip statements for 3.6 when a 3.6 test environment is added. What
do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 184960)
Time Spent: 6h (was: 5h 50m)
> Finish Python 3 porting for runners module
> ------------------------------------------
>
> Key: BEAM-5319
> URL: https://issues.apache.org/jira/browse/BEAM-5319
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 6h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
