[
https://issues.apache.org/jira/browse/BEAM-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161433#comment-17161433
]
Kenneth Knowles edited comment on BEAM-10517 at 7/20/20, 5:58 PM:
------------------------------------------------------------------
I was wrong again: {{LinkedHashMap}} was chosen here probably specifically to
allow nulls. So it is OK but the types should have been tightened.
was (Author: kenn):
I was wrong again: {{LinkedHashMap}} was chosen here probably specifically to
allow nulls. So it is data loss, not crash. Luckily in a mostly-test-runner.
> DirectRunner multi step combine drops null accumulators
> -------------------------------------------------------
>
> Key: BEAM-10517
> URL: https://issues.apache.org/jira/browse/BEAM-10517
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: P1
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When outputting accumulators in pre-combine, the direct runner iterates over
> a map of accumulators. However, since an accumulator can be null (such as in
> zetasketch) these accumulators will not be output.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
