[ 
https://issues.apache.org/jira/browse/BEAM-10595?focusedWorklogId=464190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-464190
 ]

ASF GitHub Bot logged work on BEAM-10595:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jul/20 17:46
            Start Date: 29/Jul/20 17:46
    Worklog Time Spent: 10m 
      Work Description: amaliujia commented on pull request #12400:
URL: https://github.com/apache/beam/pull/12400#issuecomment-665798357


   @ibzib in fact, this change could probably improve performance because 
search space is reduced but the result will be the same, which means less 
options to search. However, the improvement should be trivial.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 464190)
    Time Spent: 50m  (was: 40m)

> Remove rules that not work well with Java UDF
> ---------------------------------------------
>
>                 Key: BEAM-10595
>                 URL: https://issues.apache.org/jira/browse/BEAM-10595
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql-zetasql
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: P2
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> In order to support Java UDF, we need both BeamZetaSqlCalcRel and 
> BeamCalcRel. It is 
> because BeamZetaSqlCalcRel can execute ZetaSQL built-in functions while 
> BeamCalcRel
> can execute UDFs. So during planning, we expect both Filter and Project are 
> converted to
>  a Calc before merging with other Projec/Filter/Calc. Thus we should not add 
> FilterCalcMergeRuleand ProjectCalcMergeRule.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to