[
https://issues.apache.org/jira/browse/BEAM-10595?focusedWorklogId=464349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-464349
]
ASF GitHub Bot logged work on BEAM-10595:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/20 07:31
Start Date: 30/Jul/20 07:31
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #12400:
URL: https://github.com/apache/beam/pull/12400#issuecomment-666032661
It is a good point that `CalcMergeRule` and `FilterToCalcRule` should be
enough so this rule is not needed. You might ask on dev@calcite why they both
exist.
But how does this help UDFs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 464349)
Time Spent: 1h 20m (was: 1h 10m)
> Remove rules that not work well with Java UDF
> ---------------------------------------------
>
> Key: BEAM-10595
> URL: https://issues.apache.org/jira/browse/BEAM-10595
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In order to support Java UDF, we need both BeamZetaSqlCalcRel and
> BeamCalcRel. It is
> because BeamZetaSqlCalcRel can execute ZetaSQL built-in functions while
> BeamCalcRel
> can execute UDFs. So during planning, we expect both Filter and Project are
> converted to
> a Calc before merging with other Projec/Filter/Calc. Thus we should not add
> FilterCalcMergeRuleand ProjectCalcMergeRule.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
