[
https://issues.apache.org/jira/browse/BEAM-10623?focusedWorklogId=466648&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466648
]
ASF GitHub Bot logged work on BEAM-10623:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/20 07:53
Start Date: 05/Aug/20 07:53
Worklog Time Spent: 10m
Work Description: TobKed commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r465541049
##########
File path: .github/workflows/python_tests.yml
##########
@@ -0,0 +1,196 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Python tests
+
+on:
+ schedule:
+ - cron: '10 2 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['sdks/python/**', 'model/**']
+
+
+env:
+ GCP_WHEELS_STAGING_PATH: "gs://${{ secrets.GCP_BUCKET
}}/${GITHUB_REF##*/}/${GITHUB_SHA}-${GITHUB_RUN_ID}/"
+ GCP_BUCKET: ${{ secrets.GCP_BUCKET }} # beam-wheels-staging
+ GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }} # apache-beam-testing
+ GCP_REGION: ${{ secrets.GCP_REGION}} # us-central
+
+jobs:
+
+ build_python_sdk_source:
+ name: 'Build Python SDK Source'
+ if: github.repository_owner == 'apache' && (github.event_name == 'push' ||
github.event_name == 'schedule')
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Install python
+ uses: actions/setup-python@v2
+ with:
+ python-version: 3.7
+ - name: Get build dependencies
+ working-directory: ./sdks/python
+ run: pip install -r build-requirements.txt
+ - name: Install wheels
+ run: pip install wheel
+ - name: Build source
+ working-directory: ./sdks/python
+ run: python setup.py sdist --formats=zip
Review comment:
I checked it and sdist does not require wheel. Source distribution does
not contain binaries and is not python/platform specific. I simplified both
this job and passing source dist to dataflow job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 466648)
Time Spent: 2h 10m (was: 2h)
> Add workflow to run Beam python tests on Linux/Windows/Mac platforms
> --------------------------------------------------------------------
>
> Key: BEAM-10623
> URL: https://issues.apache.org/jira/browse/BEAM-10623
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, testing
> Reporter: Tobiasz Kedzierski
> Assignee: Tobiasz Kedzierski
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)