[
https://issues.apache.org/jira/browse/BEAM-10623?focusedWorklogId=466815&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466815
]
ASF GitHub Bot logged work on BEAM-10623:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/20 14:17
Start Date: 05/Aug/20 14:17
Worklog Time Spent: 10m
Work Description: TobKed commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r465753725
##########
File path: sdks/python/apache_beam/typehints/typecheck_test_py3.py
##########
@@ -92,23 +93,29 @@ def test_wrapper_pass_through(self):
# We use a file to check the result because the MyDoFn instance passed is
# not the same one that actually runs in the pipeline (it is serialized
# here and deserialized in the worker).
- with tempfile.NamedTemporaryFile(mode='w+t') as f:
- dofn = MyDoFn(f.name)
+
+ fd, path = tempfile.mkstemp()
+ try:
+ os.close(fd)
Review comment:
WDYT about adding comment in such places with JIRA ? (as you mentioned
creating JIRA in
https://github.com/apache/beam/pull/12452#discussion_r465209691)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 466815)
Time Spent: 3h 40m (was: 3.5h)
> Add workflow to run Beam python tests on Linux/Windows/Mac platforms
> --------------------------------------------------------------------
>
> Key: BEAM-10623
> URL: https://issues.apache.org/jira/browse/BEAM-10623
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, testing
> Reporter: Tobiasz Kedzierski
> Assignee: Tobiasz Kedzierski
> Priority: P2
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
