[
https://issues.apache.org/jira/browse/BEAM-2855?focusedWorklogId=467589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467589
]
ASF GitHub Bot logged work on BEAM-2855:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/20 21:48
Start Date: 06/Aug/20 21:48
Worklog Time Spent: 10m
Work Description: leiyiz commented on a change in pull request #12427:
URL: https://github.com/apache/beam/pull/12427#discussion_r466704612
##########
File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/query1.py
##########
@@ -29,20 +29,16 @@
import apache_beam as beam
from apache_beam.testing.benchmarks.nexmark.models import nexmark_model
-from apache_beam.testing.benchmarks.nexmark.nexmark_util import ParseEventFn
-from apache_beam.testing.benchmarks.nexmark.nexmark_util import display
+from apache_beam.testing.benchmarks.nexmark.queries import nexmark_query_util
def load(raw_events, query_args=None):
return (
raw_events
- | 'ParseEventFn' >> beam.ParDo(ParseEventFn())
- | 'FilterInBids' >>
- beam.Filter(lambda event: isinstance(event, nexmark_model.Bid))
+ | nexmark_query_util.JustBids()
| 'ConvertToEuro' >> beam.Map(
lambda bid: nexmark_model.Bid(
bid.auction,
- bid.bidder, (float(bid.price) * 89) // 100,
- bid.timestamp,
- bid.extra))
- | 'DisplayQuery1' >> beam.Map(display)) # pylint:
disable=expression-not-assigned
+ bid.bidder, (bid.price * 89) // 100,
Review comment:
no problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 467589)
Time Spent: 14h 50m (was: 14h 40m)
> Implement a Python version of the Nexmark queries
> -------------------------------------------------
>
> Key: BEAM-2855
> URL: https://issues.apache.org/jira/browse/BEAM-2855
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, testing, testing-nexmark
> Reporter: Ismaël Mejía
> Priority: P3
> Labels: newbie, nexmark, starter
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> Currently we have a Java only implementation of Nexmark, a python based
> implementation would be nice to have to validate the direct and dataflow
> runners, but also to validate the new support of multiple SDKs in multiple
> runners via the runner/fn API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
