[
https://issues.apache.org/jira/browse/BEAM-2855?focusedWorklogId=467590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467590
]
ASF GitHub Bot logged work on BEAM-2855:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/20 21:49
Start Date: 06/Aug/20 21:49
Worklog Time Spent: 10m
Work Description: leiyiz commented on a change in pull request #12427:
URL: https://github.com/apache/beam/pull/12427#discussion_r466704695
##########
File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/query2.py
##########
@@ -29,17 +29,15 @@
from __future__ import absolute_import
import apache_beam as beam
-from apache_beam.testing.benchmarks.nexmark.models import nexmark_model
-from apache_beam.testing.benchmarks.nexmark.nexmark_util import ParseEventFn
-from apache_beam.testing.benchmarks.nexmark.nexmark_util import display
+from apache_beam.testing.benchmarks.nexmark.models import auction_price
+from apache_beam.testing.benchmarks.nexmark.queries import nexmark_query_util
-def load(raw_events, metadata=None):
+def load(events, metadata=None):
return (
- raw_events
- | 'ParseEventFn' >> beam.ParDo(ParseEventFn())
- | 'FilterInAuctionsWithSelectedId' >> beam.Filter(
- lambda event: (
- isinstance(event, nexmark_model.Auction) and event.id ==
metadata.
- get('auction_id')))
- | 'DisplayQuery2' >> beam.Map(display)) # pylint:
disable=expression-not-assigned
+ events
+ | nexmark_query_util.JustBids()
Review comment:
yes the doc should be updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 467590)
Time Spent: 15h (was: 14h 50m)
> Implement a Python version of the Nexmark queries
> -------------------------------------------------
>
> Key: BEAM-2855
> URL: https://issues.apache.org/jira/browse/BEAM-2855
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, testing, testing-nexmark
> Reporter: Ismaël Mejía
> Priority: P3
> Labels: newbie, nexmark, starter
> Time Spent: 15h
> Remaining Estimate: 0h
>
> Currently we have a Java only implementation of Nexmark, a python based
> implementation would be nice to have to validate the direct and dataflow
> runners, but also to validate the new support of multiple SDKs in multiple
> runners via the runner/fn API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
