[
https://issues.apache.org/jira/browse/BEAM-9977?focusedWorklogId=468094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468094
]
ASF GitHub Bot logged work on BEAM-9977:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/20 22:47
Start Date: 07/Aug/20 22:47
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r467317077
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -1306,112 +1315,206 @@ public void populateDisplayData(DisplayData.Builder
builder) {
return
toBuilder().setValueDeserializerProvider(deserializerProvider).build();
}
+ /**
+ * Sets a Kafka {@link Deserializer} to interpret key bytes read from
Kafka.
+ *
+ * <p>In addition, Beam also needs a {@link Coder} to serialize and
deserialize key objects at
+ * runtime. KafkaIO tries to infer a coder for the key based on the {@link
Deserializer} class,
+ * however in case that fails, you can use {@link
#withKeyDeserializerAndCoder(Class, Coder)} to
+ * provide the key coder explicitly.
+ */
public ReadSourceDescriptors<K, V> withKeyDeserializer(
Class<? extends Deserializer<K>> keyDeserializer) {
return
withKeyDeserializerProvider(LocalDeserializerProvider.of(keyDeserializer));
}
+ /**
+ * Sets a Kafka {@link Deserializer} for interpreting key bytes read from
Kafka along with a
Review comment:
Done, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468094)
Time Spent: 21h (was: 20h 50m)
> Build Kafka Read on top of Java SplittableDoFn
> ----------------------------------------------
>
> Key: BEAM-9977
> URL: https://issues.apache.org/jira/browse/BEAM-9977
> Project: Beam
> Issue Type: New Feature
> Components: io-java-kafka
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: P2
> Time Spent: 21h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
