[
https://issues.apache.org/jira/browse/BEAM-9977?focusedWorklogId=468464&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468464
]
ASF GitHub Bot logged work on BEAM-9977:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/20 08:30
Start Date: 10/Aug/20 08:30
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on a change in pull request
#11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r467756812
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -451,7 +574,9 @@
// Set required defaults
setTopicPartitions(Collections.emptyList());
- setConsumerFactoryFn(Read.KAFKA_CONSUMER_FACTORY_FN);
+ setConsumerFactoryFn(KafkaIOUtils.KAFKA_CONSUMER_FACTORY_FN);
+ setMaxNumRecords(Long.MAX_VALUE);
Review comment:
MaxNumRecords is set 2 lines below, this line should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468464)
Time Spent: 22h (was: 21h 50m)
> Build Kafka Read on top of Java SplittableDoFn
> ----------------------------------------------
>
> Key: BEAM-9977
> URL: https://issues.apache.org/jira/browse/BEAM-9977
> Project: Beam
> Issue Type: New Feature
> Components: io-java-kafka
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: P2
> Time Spent: 22h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
