[
https://issues.apache.org/jira/browse/BEAM-10654?focusedWorklogId=468131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468131
]
ASF GitHub Bot logged work on BEAM-10654:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/20 00:47
Start Date: 08/Aug/20 00:47
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12498:
URL: https://github.com/apache/beam/pull/12498#discussion_r467339563
##########
File path: sdks/python/apache_beam/io/jdbc.py
##########
@@ -168,41 +182,33 @@ def __init__(
:param expansion_service: The address (host:port) of the ExpansionService.
"""
- super(WriteToJdbc, self).__init__(
- self.URN,
- NamedTupleBasedPayloadBuilder(
- WriteToJdbcSchema(
- driver_class_name=driver_class_name,
- jdbc_url=jdbc_url,
- username=username,
- password=password,
- statement=statement,
- connection_properties=connection_properties,
- connection_init_sqls=connection_init_sqls,
+ super(WriteToJdbc, self).__init__(
+ self.URN,
+ NamedTupleBasedPayloadBuilder(
+ ReadFromWriteToJdbcSchema(
+ location=jdbc_url,
Review comment:
Also for the shared configuration object we should disambiguate query
and statement, maybe as read_query and write_statement. The parameters for
ReadFromJdbc and WriteToJdbc could remain "query" and "statement" though since
there it's clear from context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468131)
Time Spent: 1.5h (was: 1h 20m)
> Implement ExternalSchemaIOTransformRegistrar, implement for jdbc
> ----------------------------------------------------------------
>
> Key: BEAM-10654
> URL: https://issues.apache.org/jira/browse/BEAM-10654
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Scott Lukas
> Assignee: Scott Lukas
> Priority: P2
> Labels: schema-io
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Implement ExternalSchemaIOTransformRegistrar for cross language schemaIO
> transforms. Implement JdbcSchemaIOProvider to test registrar.
> Within project:
> [https://docs.google.com/document/d/1ic3P8EVGHIydHQ-VMDKbN9kEdwm7sBXMo80VrhwksvI/edit#heading=h.x9snb54sjlu9]
> [~bhulette]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
