[
https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185325&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185325
]
ASF GitHub Bot logged work on BEAM-6439:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jan/19 16:20
Start Date: 15/Jan/19 16:20
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7514: [BEAM-6439]
Move Python Validates Runner Flink test to PreCommit.
URL: https://github.com/apache/beam/pull/7514#discussion_r247953036
##########
File path:
.test-infra/jenkins/job_PreCommit_Python_ValidatesRunner_Flink.groovy
##########
@@ -16,25 +16,18 @@
* limitations under the License.
*/
-import CommonJobProperties as commonJobProperties
-import PostcommitJobBuilder
+import PrecommitJobBuilder
// This job runs the suite of ValidatesRunner tests against the Flink runner.
-PostcommitJobBuilder.postCommitJob('beam_PostCommit_Python_VR_Flink',
- 'Run Python Flink ValidatesRunner', 'Python Flink ValidatesRunner Tests',
this) {
- description('Runs the Python ValidatesRunner suite on the Flink runner.')
-
- previousNames('beam_PostCommit_Python_PVR_Flink_Gradle')
-
- // Set common parameters.
- commonJobProperties.setTopLevelMainJobProperties(delegate)
-
- // Execute gradle task to test Python Flink Portable Runner.
- steps {
- gradle {
- rootBuildScriptDir(commonJobProperties.checkoutDir)
- tasks(':beam-sdks-python:flinkValidatesRunner')
- commonJobProperties.setGradleSwitches(delegate)
- }
- }
-}
+PrecommitJobBuilder builder = new PrecommitJobBuilder(
+ scope: this,
+ nameBase: 'Python_ValidatesRunner_Flink',
+ gradleTask: ':beam-sdks-python:flinkValidatesRunner',
+ triggerPathPatterns: [
+ '^model/.*$',
+ '^runners/.*$',
Review comment:
I think we'll want to at least catch changes in core-construction and
java-fn-execution and as well. It's pretty fast, so I think a blanket
runners/... is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 185325)
Time Spent: 10m
Remaining Estimate: 0h
> Move Python Flink VR tests to PreCommit
> ---------------------------------------
>
> Key: BEAM-6439
> URL: https://issues.apache.org/jira/browse/BEAM-6439
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink, testing
> Reporter: Robert Bradshaw
> Assignee: Jason Kuster
> Priority: Major
> Attachments: png.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Now that they're fast and stable, it would be good to catch changes that
> break this earlier.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
