[
https://issues.apache.org/jira/browse/BEAM-10427?focusedWorklogId=468790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468790
]
ASF GitHub Bot logged work on BEAM-10427:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/20 18:18
Start Date: 10/Aug/20 18:18
Worklog Time Spent: 10m
Work Description: saavannanavati commented on a change in pull request
#12242:
URL: https://github.com/apache/beam/pull/12242#discussion_r468091611
##########
File path: .test-infra/jenkins/job_LoadTests_RuntimeTypeChecking_Python.groovy
##########
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+import InfluxDBCredentialsHelper
+
+def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))
+
+def loadTestConfigurations = { datasetName ->
+ [
+ [
+ title : 'Runtime Type Checking Python Load Test: On | Simple
Type Hints',
+ test : 'python -m
apache_beam.testing.load_tests.runtime_type_check_on_test_py3',
+ runner : CommonTestProperties.Runner.DATAFLOW,
+ pipelineOptions: [
+ job_name :
'load-tests-python-dataflow-batch-runtime-type-check-1-' + now,
+ project : 'apache-beam-testing',
+ region : 'us-central1',
+ temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
+ publish_to_big_query : true,
+ metrics_dataset : datasetName,
+ metrics_table : 'python_dataflow_batch_runtime_type_check_1',
+ influx_measurement : 'python_batch_runtime_type_check_1',
+ input_options : '\'{"num_records": 0,"key_size":
0,"value_size": 0}\''
+ num_records : 1000,
+ fanout : 300,
+ num_workers : 5,
+ autoscaling_algorithm: "NONE",
+ nested_typehint: 0 // False
+ ]
+ ],
+ [
+ title : 'Runtime Type Checking Python Load Test: Off | Simple
Type Hints',
+ test : 'python -m
apache_beam.testing.load_tests.runtime_type_check_off_test_py3',
+ runner : CommonTestProperties.Runner.DATAFLOW,
+ pipelineOptions: [
+ job_name :
'load-tests-python-dataflow-batch-runtime-type-check-2-' + now,
+ project : 'apache-beam-testing',
+ region : 'us-central1',
+ temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
+ publish_to_big_query : true,
+ metrics_dataset : datasetName,
+ metrics_table : 'python_dataflow_batch_runtime_type_check_2',
+ influx_measurement : 'python_batch_runtime_type_check_2',
+ input_options : '\'{"num_records": 0,"key_size":
0,"value_size": 0}\''
+ num_records : 1000,
+ fanout : 300,
+ num_workers : 5,
+ autoscaling_algorithm: "NONE",
+ nested_typehint: 0 // False
+ ]
+ ],
+ [
+ title : 'Runtime Type Checking Python Load Test: On | Nested
Type Hints',
Review comment:
Yeah sure
I think the original goal of having both nested type hints and simple type
hints as separate tests was to see if there was any performance difference
between the two when runtime type checking was on, which would help us narrow
down whether the performance drop came from the overhead of the decorator
versus the actual type check itself, and also to test for the regressions
separately.
I can merge them if it's okay with @udim
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468790)
Time Spent: 1h 20m (was: 1h 10m)
> Benchmark Runtime Type Checking for the Python SDK
> --------------------------------------------------
>
> Key: BEAM-10427
> URL: https://issues.apache.org/jira/browse/BEAM-10427
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Saavan Nanavati
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The goal is to figure out how much slower runtime type checking is, and
> whether any improvements can be made to speed it up.
> This will take the form of a load test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
