[
https://issues.apache.org/jira/browse/BEAM-10427?focusedWorklogId=468793&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468793
]
ASF GitHub Bot logged work on BEAM-10427:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/20 18:21
Start Date: 10/Aug/20 18:21
Worklog Time Spent: 10m
Work Description: saavannanavati commented on a change in pull request
#12242:
URL: https://github.com/apache/beam/pull/12242#discussion_r468089367
##########
File path:
sdks/python/apache_beam/testing/load_tests/runtime_type_check_off_test_py3.py
##########
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""
+For more information, see documentation in the parent class.
+
+Example test run:
+
+python -m apache_beam.testing.load_tests.runtime_type_check_off_test_py3 \
+ --test-pipeline-options="
+ --project=apache-beam-testing
+ --region=us-centrall
+ --publish_to_big_query=true
+ --metrics_dataset=python_load_tests
+ --metrics_table=gbk
+ --nested_typehint=0
+ --fanout=200
+ --num_records=1000
+ --input_options='{
+ \"num_records\": 0,
+ \"key_size\": 0,
+ \"value_size\": 0
+ }'"
+"""
+
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import logging
+
+from apache_beam.testing.load_tests.base_runtime_type_check_test_py3 import \
+ BaseRunTimeTypeCheckTest
+
+
+class RunTimeTypeCheckOffTest(BaseRunTimeTypeCheckTest):
+ def __init__(self):
+ self.runtime_type_check = False
Review comment:
We looked into this but the CLI flags are only parsed after the LoadTest
has been initialized, and by that point it's too late to modify the Pipeline
options because that happens in the LoadTest constructor.. or can I still
modify the options?
It happens
[here](https://github.com/apache/beam/pull/12242/files#diff-4ecc0b51b10c78064d087c1db98ec780R105)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468793)
Time Spent: 1h 40m (was: 1.5h)
> Benchmark Runtime Type Checking for the Python SDK
> --------------------------------------------------
>
> Key: BEAM-10427
> URL: https://issues.apache.org/jira/browse/BEAM-10427
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Saavan Nanavati
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The goal is to figure out how much slower runtime type checking is, and
> whether any improvements can be made to speed it up.
> This will take the form of a load test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
