[
https://issues.apache.org/jira/browse/BEAM-10616?focusedWorklogId=469152&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469152
]
ASF GitHub Bot logged work on BEAM-10616:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/20 09:57
Start Date: 11/Aug/20 09:57
Worklog Time Spent: 10m
Work Description: kkucharc commented on a change in pull request #12435:
URL: https://github.com/apache/beam/pull/12435#discussion_r468464708
##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -125,7 +125,9 @@ def process(self, element, state=state_param):
state.add(1)
yield element
- if self.get_option_or_default('streaming', False):
+ if self.get_option_or_default(
+ 'streaming',
+ False) and self.pipeline.get_option('runner') == "PortableRunner":
Review comment:
The PortableRunner is supposed to use `StatefulLoadGenerator` to enable
streaming.
To be honest I assumed that if we are comparing core operations, we should
be using the same source method - SyntheticSources.
On the other hand maybe `StatefulLoadGenerator` should be part of
SyntheticSources. WDYT @tysonjh ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 469152)
Time Spent: 3.5h (was: 3h 20m)
> Create Streaming ParDo Python Load Test Jenkins Job
> ---------------------------------------------------
>
> Key: BEAM-10616
> URL: https://issues.apache.org/jira/browse/BEAM-10616
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: P2
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> ParDo core operation load tests for streaming with 4 tests cases that loads
> data from SyntheticSources and runs on Dataflow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
