[ 
https://issues.apache.org/jira/browse/BEAM-10616?focusedWorklogId=469331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469331
 ]

ASF GitHub Bot logged work on BEAM-10616:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Aug/20 17:34
            Start Date: 11/Aug/20 17:34
    Worklog Time Spent: 10m 
      Work Description: tysonjh commented on a change in pull request #12435:
URL: https://github.com/apache/beam/pull/12435#discussion_r468749356



##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -125,7 +125,9 @@ def process(self, element, state=state_param):
             state.add(1)
         yield element
 
-    if self.get_option_or_default('streaming', False):
+    if self.get_option_or_default(
+        'streaming',
+        False) and self.pipeline.get_option('runner') == "PortableRunner":

Review comment:
       Right, I remember you mentioned there was some issue with the 
SyntheticSource that Max ran into. Ideally Synthetic source would work for all 
standard uses but I'm not familiar with the details. How big of a change would 
it be to fix SyntheticSource?
   
   I'm OK with moving forward with this change, creating a Jira issue for 
tracking the SyntheticSource improvement, and noting it here as a TODO.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 469331)
    Time Spent: 3h 40m  (was: 3.5h)

> Create Streaming ParDo Python Load Test Jenkins Job
> ---------------------------------------------------
>
>                 Key: BEAM-10616
>                 URL: https://issues.apache.org/jira/browse/BEAM-10616
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Kasia Kucharczyk
>            Assignee: Kasia Kucharczyk
>            Priority: P2
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> ParDo core operation load tests for streaming with 4 tests cases that loads 
> data from SyntheticSources and runs on Dataflow.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to