[
https://issues.apache.org/jira/browse/BEAM-10623?focusedWorklogId=469415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469415
]
ASF GitHub Bot logged work on BEAM-10623:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/20 21:32
Start Date: 11/Aug/20 21:32
Worklog Time Spent: 10m
Work Description: TobKed commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r468876965
##########
File path: CI.md
##########
@@ -75,8 +75,28 @@ run categories. Here is a summary of the run categories with
regards of the jobs
Those jobs often have matrix run strategy which runs several different
variations of the jobs
(with different platform type / Python version to run for example)
+### Google Cloud Platform Credentials
+
+Some of the jobs require variables stored as a [GitHub
Secrets](https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets)
+to perform operations on Google Cloud Platform. Currently these jobs are
limited to Apache repository only.
+These variables are:
+ * `GCP_PROJECT_ID` - ID of the Google Cloud project. Apache/Beam repository
has it set to `apache-beam-testing`.
+ * `GCP_REGION` - Region of the bucket and dataflow jobs. Apache/Beam
repository has it set to `us-central1`.
+ * `GCP_TESTING_BUCKET` - Name of the bucket where temporary files for
Dataflow tests will be stored. Apache/Beam repository has it set to
`beam-github-actions-tests`.
+ * `GCP_SA_EMAIL` - Service account email address. This is usually of the
format `<name>@<project-id>.iam.gserviceaccount.com`.
+ * `GCP_SA_KEY` - Service account key. This key should be created and encoded
as a Base64 string (eg. `cat my-key.json | base64` on macOS).
+
+Service Account shall have following permissions:
+ * Storage Admin (roles/storage.admin)
+ * Dataflow Admin (roles/dataflow.admin)
+
+### Workflows
+
+#### Build python source distribution and wheels -
[build_wheels.yml](.github/workflows/build_wheels.yml)
+
| Job | Description
| Pull
Request Run | Direct Push/Merge Run | Scheduled Run | Requires GCP Credentials |
|-------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------|-----------------------|---------------|--------------------------|
+| Check are GCP variables set | Checks are GCP variables
are set. Jobs which required them depends on the output of this job.
| Yes
| Yes | Yes | Yes/No
|
Review comment:
I used `Check GCP variables` and also changed it in workflow itself.
Looks much more cleaner and simpler.
##########
File path: CI.md
##########
@@ -85,16 +105,15 @@ Those jobs often have matrix run strategy which runs
several different variation
| List files on Google Cloud Storage Bucket | Lists files on GCS for
verification purpose.
| -
| Yes | Yes | Yes
|
| Tag repo nightly | Tag repo with
`nightly-master` tag if build python source distribution and python wheels
finished successfully.
| - | - | Yes | -
|
-### Google Cloud Platform Credentials
-
-Some of the jobs require variables stored as a [GitHub
Secrets](https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets)
-to perform operations on Google Cloud Platform. Currently these jobs are
limited to Apache repository only.
-These variables are:
- * `GCP_SA_EMAIL` - Service account email address. This is usually of the
format `<name>@<project-id>.iam.gserviceaccount.com`.
- * `GCP_SA_KEY` - Service account key. This key should be created and encoded
as a Base64 string (eg. `cat my-key.json | base64` on macOS).
+#### Python tests - [python_tests.yml](.github/workflows/python_tests.yml)
-Service Account shall have following permissions:
- * Storage Object Admin (roles/storage.objectAdmin)
+| Job | Description
|
Pull Request Run | Direct Push/Merge Run | Scheduled Run | Requires GCP
Credentials |
+|----------------------------------|-----------------------------------------------------------------------------------------------------------------------|------------------|-----------------------|---------------|--------------------------|
+| Check are GCP variables set | Checks are GCP variables are set. Jobs
which required them depends on the output of this job.
| Yes | Yes | Yes | Yes/No
|
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 469415)
Time Spent: 7h 20m (was: 7h 10m)
> Add workflow to run Beam python tests on Linux/Windows/Mac platforms
> --------------------------------------------------------------------
>
> Key: BEAM-10623
> URL: https://issues.apache.org/jira/browse/BEAM-10623
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, testing
> Reporter: Tobiasz Kedzierski
> Assignee: Tobiasz Kedzierski
> Priority: P2
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
