[
https://issues.apache.org/jira/browse/BEAM-10623?focusedWorklogId=469446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469446
]
ASF GitHub Bot logged work on BEAM-10623:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/20 23:09
Start Date: 11/Aug/20 23:09
Worklog Time Spent: 10m
Work Description: TobKed commented on pull request #12452:
URL: https://github.com/apache/beam/pull/12452#issuecomment-672344986
> Thanks, @TobKed , I don't have additional comments. Once all reviewers,
whose feedback you expect, give their LGTM, please squash fixup commits, and
leave only the commits that you want to be added to the commit history.
I found I missed to use `TemporaryDirectory()` in
`sdks/python/apache_beam/typehints/typecheck_test_py3.py`, I fixed it.
I also added input to manual trigger so dataflow tests have to be explicitly
enabled (made them disabled by default).
Thanks for reviews @tvalentyn and all people involved in this PR. I will
create PR to Apache Infra with request for setting up proper secrets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 469446)
Time Spent: 8h 20m (was: 8h 10m)
> Add workflow to run Beam python tests on Linux/Windows/Mac platforms
> --------------------------------------------------------------------
>
> Key: BEAM-10623
> URL: https://issues.apache.org/jira/browse/BEAM-10623
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, testing
> Reporter: Tobiasz Kedzierski
> Assignee: Tobiasz Kedzierski
> Priority: P2
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
