[
https://issues.apache.org/jira/browse/BEAM-10557?focusedWorklogId=470244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470244
]
ASF GitHub Bot logged work on BEAM-10557:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/20 14:01
Start Date: 13/Aug/20 14:01
Worklog Time Spent: 10m
Work Description: sclukas77 commented on a change in pull request #12341:
URL: https://github.com/apache/beam/pull/12341#discussion_r469973877
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableProviderWrapper.java
##########
@@ -80,13 +80,17 @@ public BeamSqlTable buildBeamSqlTable(Table
tableDefinition) {
}
}
- private BeamTableStatistics getTableStatistics(PipelineOptions options) {
+ public BeamTableStatistics getTableStatistics(PipelineOptions options) {
if (isBounded().equals(PCollection.IsBounded.BOUNDED)) {
return BeamTableStatistics.BOUNDED_UNKNOWN;
}
return BeamTableStatistics.UNBOUNDED_UNKNOWN;
}
+ public BeamTableStatistics getTableStatistics(PipelineOptions options,
SchemaIO schemaIO) {
+ return getTableStatistics(options);
+ }
+
Review comment:
The reason why I added this additional getTableStatistics() function was
that DataStoreV1 is the first IO whose getTableStatistics() function relied on
the schemaIO data, and this SchemaIOTableWrapper#getTableStatistics function
could be overridden in DataStoreV1TableProvider. The other IOs so far have not
required the schemaIO. Do you think we should get rid of the other
getTableStatistics() function and always require a schemaIO, even when the
schemaIO isn't absolutely necessary? Or support both cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 470244)
Time Spent: 2.5h (was: 2h 20m)
> Move DataStoreV1 Logic to Core Beam
> -----------------------------------
>
> Key: BEAM-10557
> URL: https://issues.apache.org/jira/browse/BEAM-10557
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Scott Lukas
> Assignee: Scott Lukas
> Priority: P2
> Labels: schema-io
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Implement SchemaIO and SchemaCapableIOProvider for DataStoreV1.
> Additional details:
> [https://docs.google.com/document/d/1ic3P8EVGHIydHQ-VMDKbN9kEdwm7sBXMo80VrhwksvI/edit?ts=5ef631ef#]
> [~bhulette]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
