[
https://issues.apache.org/jira/browse/BEAM-10557?focusedWorklogId=470719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470719
]
ASF GitHub Bot logged work on BEAM-10557:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/20 14:38
Start Date: 14/Aug/20 14:38
Worklog Time Spent: 10m
Work Description: sclukas77 commented on a change in pull request #12341:
URL: https://github.com/apache/beam/pull/12341#discussion_r470663519
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableProviderWrapper.java
##########
@@ -80,13 +80,17 @@ public BeamSqlTable buildBeamSqlTable(Table
tableDefinition) {
}
}
- private BeamTableStatistics getTableStatistics(PipelineOptions options) {
+ public BeamTableStatistics getTableStatistics(PipelineOptions options) {
if (isBounded().equals(PCollection.IsBounded.BOUNDED)) {
return BeamTableStatistics.BOUNDED_UNKNOWN;
}
return BeamTableStatistics.UNBOUNDED_UNKNOWN;
}
+ public BeamTableStatistics getTableStatistics(PipelineOptions options,
SchemaIO schemaIO) {
+ return getTableStatistics(options);
+ }
+
Review comment:
I see what you mean now. I got rid of the old getTableStatistics()
function and moved the default implementation to this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 470719)
Time Spent: 3h (was: 2h 50m)
> Move DataStoreV1 Logic to Core Beam
> -----------------------------------
>
> Key: BEAM-10557
> URL: https://issues.apache.org/jira/browse/BEAM-10557
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Scott Lukas
> Assignee: Scott Lukas
> Priority: P2
> Labels: schema-io
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Implement SchemaIO and SchemaCapableIOProvider for DataStoreV1.
> Additional details:
> [https://docs.google.com/document/d/1ic3P8EVGHIydHQ-VMDKbN9kEdwm7sBXMo80VrhwksvI/edit?ts=5ef631ef#]
> [~bhulette]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
