[
https://issues.apache.org/jira/browse/BEAM-2855?focusedWorklogId=470592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470592
]
ASF GitHub Bot logged work on BEAM-2855:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/20 06:19
Start Date: 14/Aug/20 06:19
Worklog Time Spent: 10m
Work Description: leiyiz commented on a change in pull request #12580:
URL: https://github.com/apache/beam/pull/12580#discussion_r470431457
##########
File path:
sdks/python/apache_beam/testing/benchmarks/nexmark/models/bids_per_session.py
##########
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Result of Query11 and 12."""
+from __future__ import absolute_import
+
+from apache_beam.coders import coder_impl
+from apache_beam.coders.coders import FastCoder
+from apache_beam.testing.benchmarks.nexmark import nexmark_util
+
+
+class BidsPerSessionCoder(FastCoder):
Review comment:
I'm actually not sure, we need coder for the 3 models. As for the
results, IIRC according to the documentation, beam will try to infer coders if
no coder is registered. I am not sure how exactly that works and if the
inferred coder works well on all runners.
So far I forgot to register coders for some of the result models and there
seems to be no problem on the direct runner. not sure on others though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 470592)
Time Spent: 16h 40m (was: 16.5h)
> Implement a Python version of the Nexmark queries
> -------------------------------------------------
>
> Key: BEAM-2855
> URL: https://issues.apache.org/jira/browse/BEAM-2855
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, testing, testing-nexmark
> Reporter: Ismaël Mejía
> Priority: P3
> Labels: newbie, nexmark, starter
> Time Spent: 16h 40m
> Remaining Estimate: 0h
>
> Currently we have a Java only implementation of Nexmark, a python based
> implementation would be nice to have to validate the direct and dataflow
> runners, but also to validate the new support of multiple SDKs in multiple
> runners via the runner/fn API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
