[
https://issues.apache.org/jira/browse/BEAM-6024?focusedWorklogId=185540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185540
]
ASF GitHub Bot logged work on BEAM-6024:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/19 01:49
Start Date: 16/Jan/19 01:49
Worklog Time Spent: 10m
Work Description: markflyhigh commented on pull request #7423:
[BEAM-6024] Build Python 3 container image with Gradle
URL: https://github.com/apache/beam/pull/7423#discussion_r248127767
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1523,7 +1523,14 @@ artifactId=${project.name}
project.task('setupVirtualenv') {
doLast {
- project.exec { commandLine 'virtualenv', "${project.ext.envdir}" }
+ def virtualenvCmd = [
+ 'virtualenv',
+ "${project.ext.envdir}",
+ ]
+ if (project.hasProperty('python3')) {
+ virtualenvCmd += '--python=python3'
Review comment:
You are right. We should consider other version of python 3 in the future.
Currently I don't have a good answer yet. So let's use `python3` in general and
specify `--python=python35` (I think this is the right format) in virtualenv
cmd. A constant with comments sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 185540)
Time Spent: 1h 10m (was: 1h)
> Gradle setupVirtualenv supports Python 3
> ----------------------------------------
>
> Key: BEAM-6024
> URL: https://issues.apache.org/jira/browse/BEAM-6024
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-harness
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Need to depend on Python 3 virtualenv in few places:
> - Build Dataflow worker container in Python 3
> - Run ValidatesRunner and integration tests on Jenkins
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
