[ 
https://issues.apache.org/jira/browse/BEAM-6024?focusedWorklogId=186628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186628
 ]

ASF GitHub Bot logged work on BEAM-6024:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jan/19 23:50
            Start Date: 17/Jan/19 23:50
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on pull request #7423: [BEAM-6024] 
Build Python 3 container image with Gradle
URL: https://github.com/apache/beam/pull/7423#discussion_r248882024
 
 

 ##########
 File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
 ##########
 @@ -1554,9 +1554,20 @@ class BeamModulePlugin implements Plugin<Project> {
       project.ext.envdir = 
"${project.rootProject.buildDir}/gradleenv/${project.name.hashCode()}"
       project.ext.pythonRootDir = "${project.rootDir}/sdks/python"
 
+      // This is current supported Python3 version. It should match the one in
+      // sdks/python/container/py3/Dockerfile
+      final PYTHON3_VERSION = 35
 
 Review comment:
   Should this be 35 or `3.5`?
   virtualenv documentation says:  
   ```
   -p PYTHON_EXE, --python=PYTHON_EXE
                           The Python interpreter to use, e.g.,
                           --python=python3.5 will use the python3.5 interpreter
                           to create the new environment.  The default is the
                           interpreter that virtualenv was installed with
                           (/usr/bin/python3.5)
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 186628)
    Time Spent: 1h 40m  (was: 1.5h)

> Gradle setupVirtualenv supports Python 3
> ----------------------------------------
>
>                 Key: BEAM-6024
>                 URL: https://issues.apache.org/jira/browse/BEAM-6024
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-harness
>            Reporter: Mark Liu
>            Assignee: Mark Liu
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Need to depend on Python 3 virtualenv in few places:
> - Build Dataflow worker container in Python 3
> - Run ValidatesRunner and integration tests on Jenkins



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to