[ 
https://issues.apache.org/jira/browse/BEAM-10378?focusedWorklogId=471722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-471722
 ]

ASF GitHub Bot logged work on BEAM-10378:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Aug/20 23:17
            Start Date: 17/Aug/20 23:17
    Worklog Time Spent: 10m 
      Work Description: ettirapp commented on a change in pull request #12581:
URL: https://github.com/apache/beam/pull/12581#discussion_r471825367



##########
File path: 
sdks/java/io/azure/src/main/java/org/apache/beam/sdk/io/azure/blobstore/AzfsResourceId.java
##########
@@ -105,6 +129,17 @@ boolean isWildcard() {
     return GLOB_PREFIX.matcher(blob).matches();
   }
 
+  String getBlobNonWildcardPrefix() {
+    Matcher m = GLOB_PREFIX.matcher(getBlob());
+    checkArgument(
+        m.matches(), String.format("Glob expression: [%s] is not expandable.", 
getBlob()));
+    return m.group("PREFIX");
+  }
+
+  public boolean isContainer() {
+    return blob == null;

Review comment:
       It says in the javadoc for ResourceId.java that a resource id represents 
a file-like resource, so AzfsResourceId does not support resource id's without 
a container.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 471722)
    Time Spent: 21.5h  (was: 21h 20m)

> Implement an Azure blobstore filesystem for Java SDK
> ----------------------------------------------------
>
>                 Key: BEAM-10378
>                 URL: https://issues.apache.org/jira/browse/BEAM-10378
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-azure
>            Reporter: Pablo Estrada
>            Assignee: Etta Rapp
>            Priority: P2
>          Time Spent: 21.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to