[ 
https://issues.apache.org/jira/browse/BEAM-10378?focusedWorklogId=472117&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-472117
 ]

ASF GitHub Bot logged work on BEAM-10378:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Aug/20 20:45
            Start Date: 18/Aug/20 20:45
    Worklog Time Spent: 10m 
      Work Description: pabloem commented on a change in pull request #12581:
URL: https://github.com/apache/beam/pull/12581#discussion_r472482298



##########
File path: 
sdks/java/io/azure/src/main/java/org/apache/beam/sdk/io/azure/blobstore/AzureBlobStoreFileSystem.java
##########
@@ -68,6 +68,8 @@
   private static final ImmutableSet<String> NON_READ_SEEK_EFFICIENT_ENCODINGS =
       ImmutableSet.of("gzip");
 
+  private static final int expiryTime = 86400000;

Review comment:
       Constants usually have uppercase names, like so:
   
   ```suggestion
     private static final int DEFAULT_EXPIRY_TIME = 86400000;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 472117)
    Time Spent: 21h 40m  (was: 21.5h)

> Implement an Azure blobstore filesystem for Java SDK
> ----------------------------------------------------
>
>                 Key: BEAM-10378
>                 URL: https://issues.apache.org/jira/browse/BEAM-10378
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-azure
>            Reporter: Pablo Estrada
>            Assignee: Etta Rapp
>            Priority: P2
>          Time Spent: 21h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to